Skip to content

webgl_triangle: fix calculation of WASM page sizes - #192

Open
1player wants to merge 1 commit into
odin-lang:masterfrom
1player:master
Open

1player wants to merge 1 commit into
odin-lang:masterfrom
1player:master

Conversation

@1player

@1player 1player commented Nov 3, 2026

Copy link
Copy Markdown

Incidentally the correct size was returned because $MAX_MEMORY_PAGES is equivalent to $PAGE_SIZE, but still, the equation was technically incorrect and potentially confusing.

Checklist before submitting:

  • This example has been added to .github/workflows/check.yml (for automatic testing)
  • This example compiles cleanly with flags -vet -strict-style -vet-tabs -disallow-do -warnings-as-errors
  • This example the naming and style convention: https://github.com/odin-lang/examples/wiki/Naming-and-style-convention (exceptions can be made for ports of examples that need to match 1:1 to the original source).
  • By submitting, I understand that this example is made available under these licenses: Public Domain and Odin's zlib license. Only for third-party dependencies are other licenses allowed.

Incidentally the correct size was returned because $MAX_MEMORY_PAGES
is equivalent to $PAGE_SIZE, but still, the equation was technically
incorrect and potentially confusing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant